Wordpress 6.2 Error

im checking now

1 Like

Checking now as wel.

1 Like

The issue are the following lines in wp-content/themes/pro/framework/legacy/functions/plugins/cornerstone.php

line 213

add_filter( 'wp_audio_shortcode_library', 'x_native_wp_audio_shortcode_library' );

and line 252

add_filter( 'wp_video_shortcode_library', 'x_native_wp_video_shortcode_library' );

When you call wp_enqueue_script('mediaelement') in their callbacks (x_native_wp_video_shortcode_library and x_native_wp_audio_shortcode_library) it starts an infinite loop because the first call to wp_scripts() hasn’t resolved the global $wp_scripts yet which causes a call to wp_enqueue_script to instantiate a new WP_Scripts object again, and again, and again.

4 Likes

Confirmed I can update to 6.2 with this.

2 Likes

Okay great, and thanks a bunch for that @asherwunk. I’ve confirmed that’s it as well. I’m just going to remove those lines for now and we can handle properly soon if we really need to enqueue that script ourselves. We enqueue it properly elsewhere so we are all probably fine. Will be releasing an update soon everybody.

3 Likes

@charlie - The addition of return; at line 194 brought my site back online.

Thank you!

1 Like

@charlie - return; worked as a temp fix. Thanks!

2 Likes

@asherwunk and @charlie – you, sirs, deserve an award. Thanks!

1 Like

Hotfix pushed live

image

2 Likes

Amazingly quick response to this issue. Well done Themeco. In particular @charlie and @kory

EDIT: I meant @kyle but hey well done Kory too.

3 Likes

6.1.10 is going up now folks. Contact us immediately if you have any other issues.

3 Likes

Fantastic guys! Well done

1 Like

Nice work @charlie. Much appreciated.

2 Likes

Thank you so much for the restoration steps. It saved me a ton of time to have these already laid out for me - I was going in a much more labor intensive direction and your idea of just moving the Pro directory out was a fantastic one.

1 Like

Hello! I’ve deleted the old version of pro, and uploaded to the newest version about a minute ago. As soon as I activate Pro (6.1.10), the site crashes. All plugins are disabled. Am I missing something?

Can you please add the fix also to the current beta version?

1 Like

@devinfmanuel When WP_DEBUG is on what messages do you get? I would also just try again, sometimes the upload can go amiss. I would also create a different thread if you think we need to get on the site.

@striata I’ll update beta as well.

@PremierWeb I actually caught it after two sites and knew something was wrong and shut down the web server and did a search/replace on the server for the wp-config.php to change it from true to false, and then started back up the web server! Got lucky and only had two sites down.

This is making me rethink my auto update strategy! Any thoughts? I’ve not seen this happen before at this scale.

Love your work @charlie & team!!

1 Like

@charlie - How best to make these Pro updates with already impacted sites?

I have rolled back a few impacted sites, but then the auto-update for Wordpress automatically kicks in and sends it to 6.2, before I can even login to deactivate or update Pro. So it just crashes immediately again.

Apologies in advance if this has already been discussed.