Using the new "tab" keyboard shortcuts sequentially stops working – RC1

Beta
#1

I was just trying to get used to the new shortcuts for the outline, inspector, settings tabs… and ran into an issue. If you try to use them sequentially, the shortcut binding seems to get lost – so it will start using Safari’s default behavior for those shortcuts instead.

Repro:

  1. Load the builder
  2. Hit Option Command 1
  3. As soon as it switches to that tab, hit Option Command 2

Observed:
Rather than continuing to cycle through the tabs, Safari instead takes you to the second site you have listed in your Favorites list.

image

To be crystal clear, it works fine in any other circumstances – it only breaks when you try to use the shortcuts to go to several tabs one after the other without doing anything else in the builder.

#2

Thanks for the heads up on this!

1 Like
#3

@alexander, adding on to the previous issue, it appears that using the delete key (to remove an element) makes these shortcuts stop working completely.

For example, select an element, hit delete on the keyboard, select another element, then hit the shortcut to switch to the Outline tab…

#4

Hi @devinelston,

I’ve checked into this and unfortunately I don’t have a way to stop that Safari behavior if you don’t fully release the keyboard combination. You have to release it and press them down again :confused: I think it’s something in the library we’re using for shortcuts.

The second issue you’re seeing has to do with the iframe taking focus of the keyboard. If your most recent click is in the workspace the shortcuts always work. Still trying to solve that one.

#5

Fair enough for the first one. I’ll keep that in mind.

For the second issue, I was wrong. It apparently doesn’t have to do with deleting anything, but actually with what you select. The “tab shortcuts” stop working if you select a classic layout element on a page (classic row or column).

Repro:

  1. Load a page with classic layout elements on it
  2. Select a classic row or column
  3. Try one of the keyboard shortcuts, like command option 1

Observed:
In both Chrome and Safari, once you’ve selected one of the classic layouts, the tab keyboard shortcuts will not work until you refresh the page – even if you select other elements on the page.

I thought it was related to delete because I was trying out some V2 layouts on a page I built entirely in older versions of CS/Pro – so once I deleted the v2 layout, I could only click on classic elements to put focus in the workspace.

#6

… and same thing if you click one of the new DIV elements too. Once you do, you can’t use the tab keyboard shortcuts until you refresh the page.

#7

I think what’s happening is any clicks in the iframe change the browser focus to that frame, and the shortcuts stop working because the main app can’t listen to the keyboard anymore. If you click anywhere in the workspace (outside the preview frame) before entering a keyboard shortcut they should work. That’s what I’ve got to solve, propagating the shortcuts from the frame up into the main application. In Pro 3.0 I had something rigged up for this but it’s not working anymore after we removed Ember.

#8

I’m pretty sure we’re on the same page… but I want to make sure this point was clear from my side…

There seems to be something specific to classic rows & columns as well as the new div element which cause just the “tab” shortcuts (command option 1, etc) to stop working. The other shortcuts for things like shift command e work fine even after the “tab” shortcuts are no longer responsive.

If that was clear, :+1: and carry on :slight_smile:

#9

Ok gotcha! Sorry for missing that. I’ll take another look at this tomorrow.

1 Like
#10

I know this falls farther down the list of priorities, so here are some additional details I’ve gathered as I’ve been migrating a site with a fair amount of classic layouts… which means I keep clicking classic layouts which then causes some of the keyboard shortcuts to stop working.

Once you click on a classic layout (section/row/column), these keyboard shortcuts stop working:
• Any of the Command Option # options for the tabs
• Command D won’t duplicate
• Command Z won’t undo
• Command S for save will occasionally stop working as well (this one doesn’t repro consistently, but I think it might be related because it happens at times when the others stop working as well – just not every time)

For all of these, clicking anywhere on “The Bar” or using Shift Command E to bring up the Element Library will let the shortcuts start working again. So, if it’s a matter of the builder losing focus when you click a classic layout, something about The Bar brings it back.

#11

Thanks Devin! Got this one on the radar. We might have a couple things happening here, but the main problem is an issue with the iframe gaining focus when an element is inspected and the shortcuts are registered in the main app. Happens with any elements (classic or otherwise). Once that propagation issue is worked out anything else should be easy to identify and clear up. Thanks for your patience on this one.

1 Like