Undo Behavior in Beta 1

Beta
#1

Missing Changes:
I’m assuming this has something to do with the optimizations you guys turned off in this first build, but Undo seems to be missing a bunch of stuff. When hitting Undo, I’ve had it jump back 3 or 4 changes (e.g. I added an element, updated its margin, changed the background color, then modified the text – and hitting Undo goes all the way back to the default element).

Changes to Global CSS, etc.
Also, I really like how easy it is to update Global CSS, Colors, Fonts, etc without leaving the builder. However, because these changes now feel like changes you’d make to any other element on the page, it feels weird that they’re not included in the Undo history.

#2

Noted, we’ll check into the skipped updates and also you’re right, changes made to the global state should be part of the history now.

#3

I’m still seeing some inconsistencies in how undo works.

For example, I have a header with a search dropdown in it. I just added a second one (to test something), then copy/pasted the styling from original dropdown onto the new one. Then, I hit command-z and it jumped back to a state before I added the element.

In the screenshot below, the history reflects the changes I made. However, it took me all the way back to “Image Updated” with a single command-z.

image

#4

Actually, here’s a video showing it in action. I was trying to see how changes to the Layout CSS fit into the Undo History.

In the video, I delete some of the custom CSS, then hit command-z two separate times. You can see it brings back the changes within the custom css window each time I hit command-z, but also jumps several places in the history list at the same time.

#5

Thank you! I don’t have this solved for the patch we’re about to push out but I did narrow it down. If you press cmd/ctrl+z it would keep triggering the keybinding if you hold it down. We don’t have anything in place throttling this, so it’s common to press it have have multiple events triggered in a row.

#6

Update: Was able to get this resolved for the next patch. It was actually a case of the keybinding getting registered multiple times instead of just once. Now it feels much more natural, and I’ve also prevented undo/redo from firing while inputs or text editors are focused.

2 Likes