RC3 | Pro Dropdown - intentional?

Beta
#1

This is beyond minuscule but I noticed the visual separators disappeared in the Pro dropdown. Always appreciated those. :stuck_out_tongue:

Before:

After:

#2

Could you let me know if you have any javascript errors in your developer tools console? The dividers are showing on my end. They’re not native to WordPress and it’s a bit of a hack for us to add them in. We have to use javascript to add some classes after the page loads. It sounds like something is causing that to fail somehow.

#3

I’ve noticed this a long time ago. I got no dividers too. But i thought it’s a new design )

#4

We didn’t intentionally remove them, so it’s either a bug or some conflict.

If you right click and do “View Page Source” on a dashboard page you can see the server output HTML. Use ctrl/cmd + f and enter tco-ab-item-divider to search for that classname. There should be two things:

  1. CSS output:
<style id='admin-bar-inline-css' type='text/css'>
      .tco-ab-item-divider:not(:last-child) {
        margin-bottom: 5px !important;
        border-bottom: 1px solid rgba(0,0,0,0.1);
        padding-bottom: 5px !important;
        box-shadow: 0 1px 0 rgba(255,255,255,0.05)
      }
      #adminmenu li.menu-top > .wp-submenu > li.tco-menu-divider:not(:last-child) {
        position: relative;
        margin-bottom: 5px;
        border-bottom: 1px solid rgba(0, 0, 0, 0.1);
        padding-bottom: 6px;
        box-shadow: 0 1px 0 rgba(255, 255, 255, 0.05);
      }
    
</style>

And 2, Javascript output.

<script>
    jQuery(function($){

      // Add menu dividers
      $('span[data-tco-admin-menu-divider]').closest('li').addClass('tco-menu-divider');

      // Fix WordPress "Theme Options" button
      var themeOptionsUrl = 'http://example.com/pro/#/options';

      $('body').on('click', '.button[href="themes.php?page=' + themeOptionsUrl + '"]', function( e ) {
        e.preventDefault();
        window.location.href = themeOptionsUrl;
      });

    });
    </script>

Let me know if either is missing, or if you don’t mind sharing login credentials I could check myself.

#5

It appears to only be happening on the front end. WP backend has the dividers. Also, upon Viewing the page source, there does not appear to be any CSS or JS output.

#6

Cannot see this inside the code of page.

#7

Gotcha! You’re right, just on the front end. I’ll see what we can do about that.

1 Like
#8

:thumbsup:Fixed.

2 Likes
#9

Confirming. Works fine too.

#10

Awesome! Thank you :slight_smile: