Pro 4.1.5 Broke conditional loading of form CSS

Beta
#1

I use Formidable forms, but only on a couple pages. So, I have their setting turned on to only load form CSS on applicable pages.

image
image1040×274 54.7 KB

That’s worked fine with Pro, right up until 4.1.5, where it no longer loads form CSS on relevant pages.

I had this happen on one site, and thought it was being caused by an update to a separate plugin… but I just tried it on a second site, where I updated plugins one by one, and kept clearing cache and checking the form page to see when it broke… and as soon as I moved from 4.1.4 to 4.1.5, the form CSS stopped loading.

It’s fine for now because I just switched the setting to have CSS load on all pages – but for performance optimization, I’d love to be able to switch back to the prior setting.

Happy to give you folks login creds if you want to play with anything.

#2

Hi @devinelston,

I think this has something to do with how they detect the “applicable pages”. It’s probably by looking for the presence of a shortcode inside the_content. Can you let me know which element you’re using it in? And if the element has multiple places where text can be input, let me know what field you’re using. Finally, is this element inside a Global Block? I can poke around to see if there’s anything we can do about it. Thanks!

#3

@alexander, just getting back to this.

I’m using the shortcode for the form [formidable id=form-name] inside a Raw Content element placed directly on the page (no GB). I also tried the shortcode within one of the Form Integration elements too. But no dice - in both cases, as soon as I turn the setting for the form styling to “Only on applicable pages”, the CSS no longer works properly (worked fine in 4.1.4, and broke specifically with 4.1.5… and still present in 4.2.3)

#4

Thanks! Would you mind letting me know how it looks after 4.3 beta 2 which we will be rolling out shortly? (or just 4.3 since that will be going out early next week).

I’m not sure what happened in 4.1.5 to cause that. Since last week I’ve audited and standardized how we call do_shortcode in our codebase. This might help. If it’s still broken I can take a closer look.

#5

Just tried it on 4.3.1, and no dice.

Let me know how you want to proceed once all the launch feedback has calmed down. I can create a staging version of the site for you to poke around on. No rush.

#6

Hi @devinelston,

Thanks for double checking! So I just tried the free version of formidable on a page and the stylesheet does get loaded with I have Only on applicable pages selected. I’ve tried a few other permutations like inside modals, grids etc. and haven’t triggered it yet.

If you don’t mind it would be great if I could see the issue in action on your site. Maybe that will help me discern what that differences are. Thanks!

#7

Sure, spun up a staging site and put the details in a secure note in my first post. Thanks for taking a look!

#8

@alexander, are you going to be able to take a look soon? (I’d like to take that staging site down sometime soon)

#9

Hi @devinelston,

I’m sorry for not checking in on this one sooner. You can go ahed and take down the staging site. I still don’t have a solution but I was able to narrow things down. For some reason it happens when Yoast is active in addition to Pro. I’ve not discerned yet what’s going on there.

#10

No worries, thanks for taking a look!