Was this intentionally removed, or just a bug?
Double clicking the text in a button no longer brings up the inline editing controls. I can’t remember if I’ve tried this in any of the betas this round…
@devinelston I’ve given this a shot and it’s working here on my development site. Can you try on the next update (once pushed)? Should definitely still be possible. Thanks!
@alexander, I just figured it out. Using Dynamic Content within the button URL is what breaks it.
Repro:
- Add a button to the builder
- Set the URL to
{{dc:global:home_url}}/contactor something similar - Try double clicking the button text
Oh gotcha! Yes, in that case it was intentional. We disabled inline editing anywhere Dynamic Content is detected because you’re not editing a true representation of the front end in those cases. Inline editing should still work anywhere you see the green observer outline with a pencil icon.
I see. It’s a little confusing in this case because the DC is only being used in the URL – not the text of the button. But I see why you’d do that.
Ah, good point there. We were trying to avoid the whole dynamic content template string popping in and out while you enter/exit inline editing. But you’re right, in that case it wouldn’t happen. We’ll think about this a bit more. I’m not sure if it’s better to go back to supporting that, or keeping the behavioral consistency of the different observer colors hinting at what is possible.