6.4.0 B2, Modals Mobile

Beta
#1

Hey @charlie,
what is the background behind changing the html structure of modals?
With Pro 6.3 I’ve only needed one line of css to get rid of the spacing left/right, now I need three lines and have to add .x-modal-content-scroll-area besides $el. So this means when I update Pro 6.3 websites to Pro 6.4 I need to adjust the custom css everywhere :frowning:

And why it is not possible to hide the spacing left/right completely on smaller screens? Could you probably add the option “0” at “Dimensions”, which hides left/right spacing, but not top. Like this the close-x icon will be safe clickable.

Thank you and best regards :slight_smile:

1 Like
#2

I did have to change the way this area was built to get proper scrolling when you used the wheel or touch on the backdrop. The same thing will eventually be done with off-canvas to support a background image that doesn’t clip when you scroll. From what I remember there was no way around it for the modal though for this release.

Setting the dimension to 0 probably shouldn’t hide the button offscreen. It’s a bit strange how that works since it’s creating a calc() statement. I’m going to start by adding in this control to ignore this inset padding. I do lean on less CSS, but I figured you were using that as a workaround. Still plenty to cleanup with this element, but hopefully this will fix your current issue.

image

1 Like