6.0 B2 – Upgrade Issues

[devinelston]

A few issues going from 5.15 to 6 B2

1. These are drop-down elements in the Header. The one on top is 5.15, and B2 below. Note that the font weight changed.

Looking at the CSS, it appears to be putting in a string prior to the appropriate 700 weight.

2. Drop Down offsets aren’t matching. In 5.15 below, note how the drop down is aligned with the right side and bottom of the Topics toggle. And in the beta, it is shifted up and to the right.

5.15

Beta 2

3. The Drop Cap seems to be missing styling. 5.15 on the left, B2 on the right.

This styling doesn’t appear to be coming through in the beta.

4. Header classes are changed. I have some custom animations set up targeting the classes that were on the Header Bars in 5.15, and they broke in the betas. Looking at the classes, it appears there’s an e thrown into the mix for e426-4 becoming e426-e4. (5.15 Top, B2 bottom). I thought there were some changes made to classes in the last major release, but this seems new?

5. Layout assignments broke. When I first upgraded to B2, the layout assignments weren’t working – and it was showing the default layout for the stack I’m on. I just had to go into one layout and click the save button, then they started working.

6. I have a search field in one of the drop downs, and it is being marked as active every time I hover over the drop down now – even thought I have not clicked on the search field. It was not like that in 5.15.

[kory]

Howdy, @devinelston! Any chance you can provide login details to look at these things in person? There’s good stuff to go on here, but in general having access to the environment is always preferred.

---

#1. I ran a test on this and it seems to be happening only on Dropdown Elements. I am looking into this to see what might be up here (font-weights seem to be moving with other Elements as they should).

---

#2. I ran a test on this locally with an old 5.X.X site and then upgraded to 6.0.0 Beta 2. I believe in 5.X.X the margin control for the Dropdown was not working properly, as I can see the generated CSS for that control was not being output on the old site, but it was fixed for this Beta release, so perhaps you had a margin setup on the Dropdown that previously wasn’t working but now it is? My alignment / margins are all working as they should after upgrading.

---

#3. I do not believe that dropcap styling is from us. I went back through the theme all the way to version 3.0.0 and searched for a has-drop-cap class and nothing came up. Can you provide more context on how you’ve been using this / for how long? Maybe it was coming from another custom location?

---

#4. If I’m understanding what you’re saying here, you were referencing an old generated class for a custom style and now that class has changed so your style is broken? If that is correct, we always encourage users to never use those for custom styling. Those classes are built out by our system and are subject to change at any point in any release. For custom styling, always introduce your own classes via the “Customization” tab and target your Elements accordingly.

---

#5. Can you provide more context on what you mean when you say the Layout assignments broke? Are you talking about…

• The page template used for general pages (e.g. “No Container | Header, Footer,” et cetera)?
• Assignments for an actual “Layout” in the Layout Builder?
• The default “Content Layout” option from Theme Options?

I ask for clarity because we changed some defaults in these regards based on other feedback from the Beta. The “Content Layout” option in Theme Options now defaults to “Fullwidth” instead of “Content / Sidebar,” which should not be an issue unless you’ve saved your Theme Options once. That being said, we saw some reports of users having issues here, so we introduced a migration script to ensure old options were brought into the new context.

We also updated changed the default Page Template to “No Container | Header, Footer” based on additional beta feedback.

Finally, the only actual Layout Builder assignment issue I’ve seen so far in this beta was with WooCommerce templates. We did confirm that these were not migrating, but have a fix in for it. Other than that, I have personally tested old builds moving from 5.X.X to 6.0.0 and everything else remained working.

---

#6. I assume you mean this shows as active when you hover over the dropdown because you have your Dropdown set to trigger on “Hover” in the Element’s options? I can confirm that the search is showing active when a dropdown first opens…it has been so long since the last release, but I feel like this might have been introduced based on some feedback where users wanted it to auto-focus search inside Elements like this? I can dig into this a little more as it doesn’t necessarily feel like a regression to me, but I understand that it does change the experience from what it was before.

[devinelston]

Hey @kory, unfortunately it’s a local build. I could export a copy and give you a dropbox link if you wanted, though. Or you can head on over to SoCal and I’ll spring for some Starbucks.

#1

---

#2 Yeah, that must have been the problem. If I clear the margins that were already set in there, it works as expected now.

---

#3 I believe this drop cap styling is native to Gutenberg. You can get to it by selecting a block of text in a post, and flipping the toggle for Drop cap. I don’t remember when I started using this, but I thought it was part of Gutenberg blocks for a while now.

In 5.15, there was css for it in https://site.local/wp-includes/css/dist/block-library/style.min.css?ver=5.8.1. But that appears to be missing after the upgrade to 6.0 . I’m pretty sure I’m not running a custom block plugin or anything.

I do have some custom CSS to tweak a couple properties, which are why a few are struck through in the screenshot in my original post. But that was just to take what was there already, and make it more in line with the style I was working on.

---

#4 OK, got it. I feel like I had problems with that in the past, and ended up using these generated classes because they worked better. But good to know.

---

#5 Yeah, all the Archive layout conditions I had set up were ignored. For example, I had one set to show on Search, Tag & Category Archives, and Blog. These worked fine on 5.15. Then, immediately after updating to 6.0, it was showing me the default layouts from the Stack. (It did not seem to be related to the new defaults for fullwidth & content/sidebar & no container – as I had already made those changes in 5.15 I believe).

---

#6 I don’t feel strongly one way or the other here. I was just noting that it was different, as it jumped out at me immediately. I guess it’s fine, assuming that a user can input text immediately (which is what it appears to be doing).

[devinelston]

I do have a #7 now too though. Related to conditions and ACF fields. In short, a part of a layout that keys off of an ACF field doesn’t work in 6.0, but was fine in 5.15.

For articles, I’ve used ACF to create a section for references. And I give the post author a little toggle to turn on those fields.

In the single post layout, I have a references section which uses a condition for {{dc:acf:post_field field="has_references"}} == 1.

In 5.15, that section appears appropriately on the front end when an article has references. But that section is missing in 6.0.

This appears to be specific to that ACF field though. I have other conditions in that layout based on things like having tags or comments, and those sections appear to be respecting their conditions.

I bet this is one that’ll be easier to see on the site, so I’ve added details in a secure note.

[kory]

@devinelston, thanks for your feedback on all of this! I’ll definitely take you up on the Starbucks next time I’m in Cali.

---

#1. Fixed.

---

#2.

---

#3. Thanks for the context on this, that was very helpful. After poking around a bit, I can see that we do have a block of code in /includes/integration/wordpress.php that is dequeueing some styles in addition to removing some actions:

if ( apply_filters( 'cs_disable_wp_extraneous', true ) ) {

  // Disconnect Block CSS
  add_action( 'wp_enqueue_scripts', function (){
    wp_dequeue_style( 'wp-block-library' );
    wp_dequeue_style( 'wp-block-library-theme' );
    wp_dequeue_style( 'wc-block-style' ); // Remove WooCommerce block CSS
  }, 100 );

  // No Global Vars
  remove_action( 'wp_enqueue_scripts', 'wp_enqueue_global_styles' );
  remove_action( 'wp_footer', 'wp_enqueue_global_styles', 1 );

  // No Emoji detection
  remove_action( 'wp_head', 'print_emoji_detection_script', 7 );
  remove_action( 'wp_print_styles', 'print_emoji_styles' );

  // No duotone SVG
  remove_filter( 'render_block', 'wp_render_duotone_support', 10, 2 );
  remove_action( 'wp_body_open', 'wp_global_styles_render_svg_filters' );

}

I will need to do a little digging through our commits to see when this was added, but I believe it might have been done in preparation for some of the simplified Theme Options updates to come. Some of those WordPress block styles can compete with Cornerstone in weird ways, so I believe we were planning to remove them ultimately to clean up some of the confusion there between the Gutenberg world and Cornerstone.

For now, you should be able to run the following filter in your child theme’s functions.php file and add all of that back in:

add_filter( 'cs_disable_wp_extraneous', '__return_false', -1 );

That being said, I’d be curious to know your thoughts on having this stuff “off” by default vs simply leaving it in. Clearly, you are leveraging some of these features in your build, but I believe we felt it better to remove because some of the default CSS put in by WordPress is somewhat odd and always needs a bit of tweaking. Anyway, let me know on that when you have a moment!

---

#4.

---

#5. So these were assignment conditions for Layouts you had setup for archives that got “lost” in the update then, correct? If that’s the case, I know that we uncovered / fixed some of these regressions already, but I will note this situation down for us to look into and confirm it’s either fixed, or make sure we address it.

---

#6. I will make a note to look into this as it appears to not be focusing the search if it’s in another Element like the Off Canvas area, for instance.

---

#7. We have taken note of this and are looking into it at the moment. Thanks!

[charlie]

Hey thanks a bunch for testing. For the ACF issue on your site I’m seeing the acf conditions work. Which post was in question? To test I’d create a raw content element and paste the following to see what you are getting per post if something is off.

{{dc:acf:post_field field="has_references"}}

[devinelston]

@kory Coffee

#3 That’s a tough call. I personally lean towards having all the styling that comes from Gutenberg on by default, as users might be used to it on other sites before moving over to Pro/X. But then off by default for whatever new “theme-free” version of CS you guys are working on. (But I’m not privy to those other complications you mentioned, so that’s just my $0.02)

#5 Correct, assignment conditions. They were all still saved on the layout, but were ignored until I opened the layout and hit save.

@Charlie, howdy! It was the post specifically mentioned in the secure note where I shared the download link and credentials. It’s called “What is retirement”. There should be a whole big block of numbered references below the post, but they were missing after the upgrade to 6.0. I’ll have to try that DC a bit later though.

[charlie]

Hey @devinelston , I was able to recreate this on your site and saw that the has_references was set in the gutenberg. Resaving in gutenburg and reloading fixed it.

However, we made some fixes towards layouts and I wasn’t able to recreate it in our current internal builds after resetting my db back to your local.sql, so why don’t we circle back to this next release which could be today or early next week. Thanks, hope you have a great weekend.

[devinelston]

Sounds good, thanks @charlie

[devinelston]

@Charlie @kory

#5 is still an issue. I started with a fresh clone of that site on 5.15, and updated it to beta 3. None of the layout assignments were respected after the update, though they worked fine on 5.15.

#7 is still a problem too. On that same fresh clone & update, once I got the layout assignments saved, that references section based on the ACF condition is still missing too.

[xRae]

I had the same issue with #5 updating a site to test in beta 3. Had to re-save the assignments to get them to work.

I also lost all of the ‘default’ layouts (those that took priority if nothing else was specifically assigned.). They wouldn’t show in the document listing until I flushed the Cornerstone system cache. After that, they appeared in the document list I was able to fix those by saving.

This is a local test, so not sure I can be much help understanding what is wrong other than it happened to me also.

[kory]

Sorry to hear this is still happening, @devinelston. I have noted down #5 and #7 as specific line-items to look into. Thanks for your feedback as well, @xRae, it has been noted.

[charlie]

Hey @devinelston always nice to hear from you. I’m sorry, but I’m having a hard time seeing what you are seeing on your site. Knowing these answer can narrow the scope of my investigation. Thank you very much for taking the time to test our beta.

5

on /?s=test you are not getting the archive layout All Archives and on the homepage you not getting the archive layout Stories Layout? What layout is being used? Can you try the following.

• Does switching from your child theme to the regular theme fix this?
• Clear the cornerstone cache, did that fix it?
• Clear SG Optimizer cache, did that fix it?
• Is it possible to put this on a live staging site?

7

If you have time could you try some of the following to narrow down what we need to fix.

• if this is working after a cache clear let me know.
• On the preview popup when you switch your post from another post to what is retirement does that fix the issue?
• {{dc:acf:post_field field="has_references"}} If you place this in a text or raw content field what do you get? Should be either 1 or nothing.

[devinelston]

Hey @Charlie @kory, I don’t have much time to test this during the week. But here are some answers.

Perhaps more importantly, attached is a dropbox video showing most of what you asked in one video.

#5

The video starts with everything displaying totally fine using Pro 5.15, and then as soon as I install Beta 3 and refresh all the pages, you can see for yourself what’s happening. I believe every layout is just whatever the defaults are for the Integrity stack.

As you can see, I cleared the caches and switched away from the child theme, and even cleared cache again. No go. Only opening a layout and saving it caused the assignments to start working again.

#7
In the video, you can see where that shortcode is outputting a 1 on the page (I circle it with the cursor). And immediately after the update, it’s still doing so – but the references at the bottom are no longer showing.

After I stopped recording, I tried looking at that particular All Posts layout in the builder, and the reference section displays perfectly fine within the builder. Just not on the front end.

I have now cloned and upgraded this site at least 5 times, and this all is reproducible every single time.

[charlie]

@devinelston Hey Devin thanks so much for this. I’ll take a look today.

[charlie]

@devinelston Hey Devin thanks so much for your patience. We will have a fix for your layout assignments in the next release. That was a fun one for me because you didn’t even need to save, just visit Cornerstone and the migration would of happened. You won’t need to do that in the next release although you will need to reset your DB (or the posts table) if you want to try to recreate the issue. Please contact us if you have any other issues. I hope you have a great day.

[devinelston]

@charlie, thanks! And sorry, maybe I’m missing it in your reply, but is the ACF issue going to be fixed too?

[charlie]

@devinelston Hey Devin. So ACF wasn’t the problem in these particular instances unless you are referring to something other then #5 and #7? We migrated layouts to different post_types to quicken DB grabs and the migration was not happening on startup. We do have some other ACF fixes coming in though, so please get creative and let us know if you have any other issues.

[devinelston]

@charlie great! When’s the next Beta going to be released so I can hammer on it some more?

[charlie]

Sometime this week my friend! most likely. I can probably give you a better timeline after today.