5.2.0 B1 – Can double click button text in component

Beta
#1

Echoing everyone else, this is super rad – I’m looking forward to playing with it more. (Components were effectively my first feature request when I met Kyle & Scott back in 2018)

In very brief testing, I noticed that if I make a button component – but don’t want the text editable via a parameter – that I’m still able to double click and edit the text in the builder. Sort of.

Repro:

  1. Create a component group
  2. Add a button with the text set to Can't change me
  3. Style the button, and add some parameters (but don’t use one of those parameters for the text of the button)
  4. Set that component for export
  5. Go to a page editor, and add that component to the page
  6. In the builder preview, double click the text on the button and change it to Just did
  7. Save

Observed: The button text is editable in the preview. However, after saving, that new Just did text is never shown on the front end. And if you refresh the builder, the text will revert to the original Can't change me text. HOWEVER, if you then double click the text again, it will show you the Just did value once again. :crazy_face:

#2

Thank you! Fixed. Inline Editing shouldn’t be possible like that, since in the current form it updates an actual element property. The bug right now is like updating a property that will never be used anywhere. We might add it back in later, but it would probably require some extra setup on the given parameter and might even need to include a wrapping HTML tag.

3 Likes