Two New Bugs

Latest update has two bugs that I discovered after using Pro 2.3.3 for 10 minutes:

  1. Copy a headline with graphic to another column. Double click to edit the text, results in graphic having a phantom top margin added that is impossible to remove. If you click “Edit text” from sidebar instead of double clicking, this issue does not occur.

  2. When adding a new row with multiple columns, all but the first column have no defaults set as all. Everything from the base font size to z index needs to be filled in manually. This is a step backwards and cannot possibly be intentional.

Beta testing still needs improvement guys.

Hello @co50,

Thanks for updating writing in and sharing the feedback.

I tested the inputs you have shared regarding headline and row with multiple columns in my local Pro Theme Setup. However, I am not able to replicate the issue on my end. Is it possible for you to share some screenshots or screencasts? I would like to take a closer look.

Thanks.

I’ve made videos showing the issues.

Phantom top margin on text graphic…
Please see: http://s000.tinyupload.com/index.php?file_id=73473571737169363309

2nd, 3rd columns have no defaults…
Please see: http://s000.tinyupload.com/index.php?file_id=62231629638894753136

Thanks for the videos! That really helps. We’ve fixed the second issue and that will be in the next update.

I’ve tried to reproduce the issue where inline editing pushes down the graphic but it’s not happening for me. I’ve tried a few different settings combinations but it always stays in the same place. Would you mind saving that page as a template and uploading it so I can try with your exact setup? Thanks!

Can’t even upload a template here. Sheesh. Ironic that Themeco is still restricting uploads to a handful of file formats that worked well in 1998. It’s 2018, when are you guys going to start allowing files of any reasonable type to be uploaded?? It’s really annoying and it limits the number of bugs I report - having to keep using 3rd party sites because whoever is running APEX is incompetent or lazy, isn’t my cup of tea.

Template is here: removed

Please mask the URL when done. BTW I’ve been able to replicate this on the Headline element on multiple websites we manage with Pro. It’s adding a phantom 0.5 em or so bottom margin randomly when double clicking the headline. Doesn’t happen all the time. So it’s not just tied to having a graphic alongside it.

EDIT: Discovered that to fix the phantom margin issue, click the Edit Text link in the sidebar for that headline, and then change the text to anything. The margin suddenly vanishes.

Thanks! Ok, I see what’s happening here. You’re setting the tag on your headline element to div. This creates somewhat of a unique situation for inline editing.
When you start inline editing it will decide which mode to use depending on the type of tag you’re working on. Notice how when you’re using a div you get the full editing toolbar, but when you are editing a headline or span tag it’s the smaller version.

When you’re editing a div the inline editing will always set a format which defaults to “Paragraph”. This is added as a wrapping tag. The spacing you’re seeing is because the paragraph is being added when you start the editing process. There is no way to remove this when using either inline editing or the Rich Text mode of the editor. We (on the theme development site) can’t add styling to remove the spacing as it is expected to have a consistent spacing when using paragraphs.

The conflict is that when you’re using a graphic it is affected by the paragraph spacing. It’s very unlikely you’d ever want this kind of markup if you were hand-coding a site. Because of Pro’s complexity and the sheer number of ways features can be combined it’s inevitable to run into cases like this. Our position is rather than removing or limited features because combing them can lead to adverse effects, we’d rather give you all the options and let you decide what to use. Even having the option to wrap a headline in a div is somewhat unusual, but we wanted to make it available for anyone who needed it.

Here are some suggestions.

  • Use a span instead of a div. This will make things inline again and help you avoid the wrapping tag you the inline
  • If you want to keep the div > p structure you can add some custom css the element CSS below should work
$el p:last-child {
  margin-bottom:0;
}

Thanks man. And super-ultra-thanks for being one of few support reps I’ve dealt with @ Themeco who consistently gives in-depth, concise responses every time. Kudos buddy. Tell Kyle not to lose you. :slight_smile:

You are most welcome @co50.

By the way, Alex is one of our developers at Theme.co.

This topic was automatically closed 10 days after the last reply. New replies are no longer allowed.