Repurposing Provider Palooza

Support
#17

Ok, we’re getting closer to this working I think.

I set a test advisory to expire 4th May 2021 at 14:40 and at 14:40 it disappeared from the status page which is great but the No Advisories panel did not take it’s place…

It seems setting No Advisories conditions as Provider Output is empty doesn’t show once there’s no active advisories. Can you advise?

Note: I have changed Advisories conditions to {{dc:global:date format="Y-m-d\TH:i:sO"}} before {{dc:acf:post_field field="valid_to"}} this seems to work as per requirements.

#18

Hey Daniel,

The condition for No Advisories then should be the reverse of your Advisories but this time, you use OR logic instead of AND because you’ll want that if any condition is TRUE, the element will be displayed. In the AND logic, all conditioins MUST be TRUE. So for the No Advisories:

  • Provider Output is empty = false because you have set a date
  • Current date/time after Valid To date = false because date is yet to come
  • Current date/time before Valid From date = true because date is before current date

In the screenshot below, you’ll see the No Advisories showing.

image
image910×347 19.6 KB

Hope that helps.

#19

Can you take a look? When a advisory is in date it’s showing both panels. You’ll need to login.

Clearly, I have not got the hang of this :sweat_smile:

screenshot 2021-05-04 at 20.25.13
screenshot 2021-05-04 at 20.25.131361×914 111 KB

#20

Hey Daniel,

The No Advisories conditions are all false so not sure why it’s showing up. I might be missing something so I’ll consult with Alex.

Please stay tuned.

1 Like
#21

Any update @christian @alexander :slight_smile:

#22

Hi @dlukefinch,

I’m sorry for the delay here. Unfortunately there isn’t a condition you can add that will satisfy that “No advisories” panel based on the Looper itself. As long as advisories exist (regardless of their dates) the provider will not be considered empty.

There are two ways I can think of to solve this. The first option would be creating a custom provider. You would need to make a PHP function to retrieve the ACF fields and filter out items that don’t satisfy the date check. Doing this gives you full control over the data and because it would only return active advisories, you could use the “empty” condition of the Looper Provider. Doing this is a bit more involved and not something I can help with in support since it gets into custom development.

Another idea would be solving it with a little javascript. Try adding `active-advisory` to the same element that has the date condition. If any advisories are on the page, the body will get a `has-advisory` class. 
jQuery(function(){
if (document.querySelector('.active-advisory')) {
  document.body.classList.add('has-advisory')
}
})

Then you can use the class to hide the no advisories message with some Element CSS on that element.

body:not(.has-advisory) $el {
  display: none;
}

This CSS/JS option is definitely more of a workaround to the custom looper, but it would be easier to implement.

#23

Hello @alexander

Ok, would you consider adding that kind of provider? I’d imagine it would be an easier job for you and the rest of the Theme Co family would probably find it useful.

In the mean time I have added the second option. Oddly, within the preview it’s working but not when I view the site normally. I have cleared cache many times.

screenshot 2021-05-11 at 14.59.28
screenshot 2021-05-11 at 14.59.281428×914 179 KB
screenshot 2021-05-11 at 14.59.04
screenshot 2021-05-11 at 14.59.041431×920 197 KB

#24

Hey Daniel,

The CSS that would work is this:

.has-advisory $el {
  display: none;
}

Alex now knows this limitation and I believe if there’s a way to easily achieve this in the future, it would surely be added.

Hope that helps.

#25

Hey Christian,

Thanks. Looks like it’s working. I have noticed the No Advisories panel shows briefly while loading. I’m wondering if there’s anything that can be done about this?

See here: https://a.cl.ly/X6ue19zD

#26

Hey Daniel,

Regretfully, that has no solution for now. It would require more custom coding so this is going more involved so we can only continue with this in our One plan where we can answer custom development questions.

Thank you for understanding.

#27

Hey,

With all due respect and while I understand it’s slightly out of scope you did say you’d assist me in getting this working.

and yet you’re bailing out at the last hurdle? Frustrating to say the least. I have no problem paying for One plan and have considered it but don’t see the point considering the job is nearly done.

:man_shrugging:

#28

Hey Daniel,

I’m not bailing out. For that quick display of “No Advisory” element, I said:

Yes, it’s seemingly just a small part or nearly done but I would not say there’s currently no solution if there’s a simple one, or at least for now I could not think of any. That is why I recommended one because this takes some custom development time. If we continue working on this, this means all customers can request anything they wish.

I did say we’re happy to help to make this setup as an example and we did. Both Advisories and No Advisories are working now except that last seemingly simple problem of the quick display of the No Advisories element.

Please understand that even by that, we did beyond the scope of product support already. I’ll post this as a feature request so our development team will know about this case. Alex already knows but it would be good to note.

Again, thank you for understanding.

#29

I understand @christian and I am sorry for coming across ungrateful. Thank you for working on that.

I am looking at a solution to that as well on Stack Exchange and one of my team has posted here: https://stackoverflow.com/questions/67540905/element-flashing-on-load

I have also contacted WPMUDEV but regretfully I don’t have the extra money to spend on One right now.

#30

@christian @alexander Had a chat with WPMUDEV.

They seem to think “the issue is mainly that your builder loads CSS later than the HTML Body content, and this causes that blinking issue.” they added

#cs-content .x-section .active-advisory { display: none ; }

to Appearance > Additional CSS within Wordpress and it showed but the conditions didn’t work as it was outside of the builder. Any thoughts?

#31

Hey Daniel,

I am aware of the CSS loading and that’s the reason why there’s a bit of delay for the No Advisories to hide. There is currently no solution I could think of.

Thanks.

#32

Ok. Probably not worth using One in that case? Or is there?

#33

Hi @dlukefinch,

They seem to think “the issue is mainly that your builder loads CSS later than the HTML Body content, and this causes that blinking issue.” they added

All the CSS loads at the same time, but that javascript snippet doesn’t run until after the page loads. That’s why the flicker happens. Another approach would be to invert how the state is managed:

// add "no-advisories" to the body if we don't find any on the page.
jQuery(function(){
  if (!document.querySelector('.active-advisory')) {
    document.body.classList.add('no-advisories')
  }
});

/* Hide the "no advisory" message until the class is present
body:not(.no-advisories) $el {
  display: none;
}

This should cause the “No Advisory” message to always be hidden, but pop in after a slight delay when no advisories are found.

#34

Hello @alexander

There’s a few minutes delay in the " no advisory" panel hiding/showing, times it doesn’t work at all which is not ideal as I’m sure you can imagine but it’s progress at least.

#37

This topic was automatically closed 10 days after the last reply. New replies are no longer allowed.

#38