Potential Bug - Imported template overriding existing theme colours

[scotbaston]

Hi Guys,

I imported a contact form template from one of my other sites, into a new new I was developing, and when the template loaded into Pro it overwrote the existing global colours.

I would expect a template to add its colours rather than overwriting the existing colours.

Also, I could find no way to ‘Undo’ these changes other than manually changing the globals colours back to their original values.

I have fixed the localised issue so don’t have an example, but I suspect this would be repeatable

Any chance of looking into this please, and letting me know any solutions

best wishes

Scot

[ruenel]

Hello Scot,

Thanks for writing in! I can confirmed that this is known conflict in the latest release. Please make sure that you have update it to the latest version of Pro theme which is 3.1.2.

This happens because importing a color will overwrite a color with the same ID.

There’s also a quirk in the behavior of the first 4 colors that already exist when you install Pro. Their IDs are hardcoded. There’s probably a better way to go about it, but they were hardcoded because you might start using a color before the color manager is saved. This exacerbates the issue because many users find it more natural to simply rename the four starter colors instead of delete and create new ones.

Our developers are already aware of this issue. The assets in the Design Cloud has been modified as well to prevent the issue from happening.

Regards.

[scotbaston]

Thanks @RueNel,

I already am on 3.1.2 for all of my Pro sites, so I guess a fix for this is not yet ready?

surely a way forward would be to check for the existence of Colour IDs when a template is imported? and if it does exist, to rename the new IDs or not overwrite the ID that already exists? ie give priority to the existing site design, rather than the file being imported

or set IDs to be appended with a site ID, so that colours from another site (or design cloud) can’t match those of the site being imported into.

or even a warning, that

I’m sure it is more complex than that, but equally I have all faith in the developers to find a good solution

[matt]

Hey Scot,

Which contact form template was it? It’s a straightforward fix once I know which one it is and I can get it updated in Design Cloud so it does not affect you or other users again.

Thanks for bringing it to our attention.

Matt

[scotbaston]

Hey Matt

It was from one of my other site builds rather than Design cloud so I’m not sure there is anything to do

Plus in this instance I fixed the issue by overwriting the colours again

[matt]

Ah ok, Scot, my misunderstanding. I thought the contact form had originated from Design Cloud. I appreciate what you’re saying now and we’ll chat internally about this and decide how best to proceed.

Thanks again.