Issues after latest update

[oriol]

Hi, after updating, my site has a couple of issues.

See: https://staging-logoglo-newsite.kinsta.cloud/

The menu, is showing both the desktop and mobile version at the same time:

And further down the page, there is an element that should be hidden on smaller breakpoints, but is showing them both:

I have cleared caches, and tested with plugins disabled etc, issue is still there.

[charlie]

I think you might be missing a closing tag. I would look for something like the below. The problem being that since breakpoints are generated dynamically they are now with the general CSS. During the minification with broken CSS this can cause issues. Adding the following filter will also prevent the issue and give you an opportunity to figure out which element has the issue e263. The filter really should be a theme option for just in case scenarios.

$el {
    overflow-y: scroll;
    overflow-x: hidden;

add_filter("cs_debug_css", "__return_true");

[oriol]

Thanks, but where is this code on my site?

[charlie]

I believe it’s Custom Element CSS. Look for e263 in the dev tools > Document Elements. I’m also going to move the breakpoint generation CSS up before all the custom CSS to prevent this from happening as well. It’s a minification issue. It will most likely be an update next week.

[simeoned]

@charlie

I am hearing some chatter (though, admittedly, I have not attempted this myself) that there are some issues presenting when upgrading to 6.3.3 if there are any of the older Global Blocks present and used on the site. Here is the report I saw on an external forum:

Thus far, two issues have arisen with pages/posts with legacy Global Blocks.

1. Hide on breakpoints in the element stops working on the page/post. Even though the classes still exist and show on the page, they’re ignored. So if you have hidden mobile content, it will show on desktop pages as well. I don’t know the exact reason for this, I chose to spend my time removing Global Blocks instead of tracking down the issue. Regular CSS media queries aren’t impacted, just the GUI breakpoint selectors.

2. If you use WP native comments, the comment submission form periodically doesn’t show. Again, I didn’t work to find out exactly what the issue was, just got rid of the legacy Global Blocks on the page and it resolved.

Have you guys seen any problems like this or similar (there may be others, I don’t know)? I have a site which needs to be upgraded from 5.1.5 still which uses the GBs from that time in Pro’s history extensively. If this is going to cause a huge headache, I’d like to see if you have this on your radar and could possibly address it in advance of my needed maintenance on that site. There are probably many others I’ll need to look at as well but the one I am referring to is critical and uses the GBs heavily.

Thanks,
Dan

[charlie]

#1 sounds related to this thread with a minification. Changing the priority the breakpoints are outputted to the page will fix this, unless I’m missing the issue from that post.
#2 I did not have this issue with a Global Block in Pro6 when I just tried. I would probably need to see the site, but In general GlobalBlocks are pretty similar codewise as Pro5, with the added individual Components feature and just calling them Components.

If you have a lot of GBs it’d probably try out a staging first. I do think most Pro5 to Pro6 issues currently are based on Theme Options, Classic Elements, and a couple of missing features. If there are some issues with older GBs we can definitely prioritize that. Have a great day and let me know if this helps.

[simeoned]

Thanks @charlie,

Not quite ready to pull the trigger just yet on that particular site. But I will start a new thread if I need to. And of course I’ll go staging first and test thoroughly before pushing to production. We’ll see how it goes!

Thanks

[Hyperbits]

@charlie. I am having this exact issue #1 that @simeoned brought up. It appears that all of the breakpoints on my page are being ignored. You can see here:

I went through and tried to find any extraneous CSS but could not find any that might lead to this. We are not able to wait a week for the next update to come out to fix this issue as it is breaking (at least) our most important landing page. What would you recommend doing? Can I get a previous Pro 6 version from my Theme.co account somewhere while we wait for the update? All I am seeing is 5.1.5 which is 1.5 years old so I’m thinking that might not work well either.

Thank you.

[charlie]

@Hyperbits . Adding that to the site splits up each style into it’s own tag and will fix the issue for now and let you debug. We definitely need to setup 6.2 as the stable version in your downloads. We planned on leaving Pro5 up, given how long it ran, but I think we’ll be adding it into to “Legacy” download section. I’ll look into a release tomorrow if 6.3.4 is ready. Let me know if that helps.

add_filter("cs_debug_css", "__return_true");

[Hyperbits]

Thank you @charlie. I did actually find the CSS culprit on the page and got it fixed. Definitely having 6.2 as the stable version would be helpful in case we run into any issues in the future.

Thanks again.

[tashitendrel]

Hi, I have exactly the same issue. The hidden elements show up everywhere on pages, posts, header footer. The Posts are made only from the new elements (not classical).
Adding this: add_filter(“cs_debug_css”, “__return_true”);
helped right now.

[oriol]

Awesome, thanks, I think I will wait for the update, hopefully it gets fixed

[prakash_s]

You are most welcome @oriol

[simeoned]

Update to 6.3.4 from July 31:

Bugfix: Breakpoint generated hide classes were outputted below all custom CSS and sites with broken CSS would lose all hide classes

Any chance this will address the issue I asked about above? What do you think @charlie?

[charlie]

Yes that change log item fixes the Breakpoint hide classes issue outlined in this thread. Let us know if you still have an issue there.

For #2. I wouldn’t be surprised if that fix also fixes that issue. Create a new thread if you’re having an issue with global blocks. Thanks! This issue might also be affecting other elements which is why I’m probably removing that part of the shim for now 6.3.3 Bug - Mobile Nav Button Styling

[simeoned]

Cool cool. I haven’t started to update any complex sites just yet… only doing the minor/simple ones now.

I’ll report back , creating any new threads as needed if I run into anything as I do.
Thanks!

[oriol]

I can confirm, latesrelease has fixed thing. Thanks!