Favicon, nav bar menu, landing page

[Cherylwoodman]

Hi Themeco team,

I have 3 different issues i’d love your help with;

1. My favicon (since the theme update) has not been showing on certain pages e.g. here > http://www.honestyforyourskin.co.uk/the-ordinary-skincare-routine-regimen/

2. My nav bar is now un-collapsed permanently on mobile http://www.honestyforyourskin.co.uk/skincare-blog/

3. One of your colleagues gave me a snippet of code to correct this button misalignment - however the theme update seem to have stopped it from working > https://www.screencast.com/t/AeWm1dKps

Thanks so much!

Cheryl

[rad]

Hi @Cherylwoodman,

Thanks for reaching out.

1. I can see the icons, have you restored it to the older version again? If yes, then I can’t check the issue. It still in the older version and the icon library changes are only available in the latest versions.

2. I can verify this, do you have a custom header in your child theme? It seems the mobile class isn’t switching or toggling, but the sub-menu works so it might not be javascript related. I recommend activating the main theme for testing (disabling the child theme), then let us know.

3. May I know what snippet? It’s not aligned due to margin and you can set the margin to 0px. Though, it makes affect its rendering in all device view. Instead, please add this to your button’s Element CSS.

@media ( max-width: 767px ) {
$el {
margin: inherit 0px;
}
}

Thanks!

[Cherylwoodman]

Hi Rad,

Thank you for helping, here’s where I’m at;

1. Oh really you can see them on this page for instance > http://www.honestyforyourskin.co.uk/how-to-use-the-inkey-list-skincare/ this is what i see > https://www.screencast.com/t/qFwHBBasDo I’m not 100% sure what you mean as old version?

2. My header is only customised using your cornerstone options/css from your team. Can you talk me through step by step to check what you suggest?

3. I’ve added this code, but it’s not made a difference.

[rad]

Hi @Cherylwoodman,

1. I saw X 6.1.6 and Cornerstone 3.1.6, but looks like you have updated it now to X 6.2.5. But your cornerstone remains on version 3.1.6. Please update it first, else, icons will not appear correctly.

2. Maybe it’s just due to outdated cornerstone, please update it first and let’s check it again.

3. Please provide your admin login credentials in a secure note, but make sure to update cornerstone first. I don’t see that CSS being implemented. I’ll check it

Thanks!

[Cherylwoodman]

Hi Rad,

1. I’ve just done this but with no change.

2. I’ve just updated but it’s still un-collapsed.

3. I’ll leave in a secure note below;

[thai]

Hi There,

1. From the version X 6.1.0, we have migrated to native WordPress “Site Icon” settings for cleaner brand management and since Wordpress has native feature for favicons. Please add your favicon under Customize > Site Identity > Site Icon.

2. I could see that you’ve copied the _nav-primary.php file to the child theme. Please compare and update it to the latest version:

<?php

// =============================================================================
// VIEWS/GLOBAL/_NAV-PRIMARY.PHP
// -----------------------------------------------------------------------------
// Outputs the primary nav.
// =============================================================================

if( function_exists( 'ubermenu' ) && $config_id = ubermenu_get_menu_instance_by_theme_location( 'primary' ) ):
	ubermenu( $config_id, array( 'theme_location' => 'primary') );
 else: ?>

<a href="#" id="x-btn-navbar" class="x-btn-navbar collapsed" data-x-toggle="collapse-b" data-x-toggleable="x-nav-wrap-mobile" aria-selected="false" aria-expanded="false" aria-controls="x-widgetbar">
  <i class="x-icon-bars" data-x-icon-s="&#xf0c9;"></i>
  <span class="visually-hidden"><?php _e( 'Navigation', '__x__' ); ?></span>
</a>

<nav class="x-nav-wrap desktop" role="navigation">
  <?php x_output_primary_navigation(); ?>
</nav>

<div id="x-nav-wrap-mobile" class="x-nav-wrap mobile x-collapsed" data-x-toggleable="x-nav-wrap-mobile" data-x-toggle-collapse="1" aria-hidden="true" aria-labelledby="x-btn-navbar">
  <?php x_output_primary_navigation(); ?>
</div>

<?php endif; ?>

3. Please try adding this element CSS to the Continue to Blog button instead. Currently, I don’t see any element CSS in that button:

@media (max-width: 480px){
  $el {
    margin: 25p 0 0 !important;
  }
}

Let us know how it goes!

[Cherylwoodman]

Thanks Thai;

1. Works a treat!

2. Worked even more of a treat - thankyou Thai!!

3. I’ve added this in - however there’s no change > https://www.screencast.com/t/VMX10d32y It’s also strange when I go into edit in cornerstone today, only 1 button shows. Why is this?

[christian]

Hey @Cherylwoodman,

The missing button was caused by the greater than > character. It is not accepted for the button text field because that is used for HTML and it is treated as broken. Please use the equivalent HTML entity instead and it’s >. For more HTMl entities, you can check this site http://www.amp-what.com.

See https://youtu.be/dhsbuvLG5_k and https://youtu.be/j6QAfAdt5kQ

Hope that helps.