in the header builder using an ‘navigation inline’ it no longer adds an id to the ul element.
Also the content editor doesn’t work at all, and I’ve disabled all my plugins.
Hello @alex5252,
Thanks for writing in and sorry to hear you seem to be having some issues.
Regarding the Navigation Inline element no longer adding an id attribute to the nested <ul> elements, this was part of an effort to clean up how some of the markup from our v2 Elements is generated. In short, when an ID is added to an element, we always attempt to put that ID on the outer most tag that contains things. On relatively simple elements such as Text, this is pretty straightforward. It gets a little tricker on elements that have much more complex markup, nested partials, et cetera.
For instance, if you add an ID of my-nav to a Navigation Dropdown element, what happens is that we add my-nav as an id to the outer wrapper that contains the toggle and the dropdown, then we add my-nav-anchor-toggle to the toggle and my-nav-dropdown to the dropdown because these can be though of as “top level” for their respective parts of the Element. The toggle uses our “Anchor” partial, which houses complex markup, and the “Dropdown” itself is a partial, which can house all sorts of content such as navigations, carts, custom content, et cetera. Also, there is only one of each of these items, making it possible for us to add IDs, because there can only be one unique ID assigned to an individual element per page (which is why we append the -anchor-toggle and -dropdown suffixes on those pieces). Note also that we do not add any more IDs to any potential nested dropdowns in the first level, just the top.
As for Navigation Inline, the menu wrapper itself that holds the top level links and all dropdowns is what would receive my-nav as the ID in this case, but since it’s markup isn’t split out into multiple places like our previous example, there’s nothing else to a potential ID to. Since the Navigation Inline Element might contain zero, one, or many dropdowns, all at potential levels of nesting, there’s not consistent way to know how to apply them, and it also might lead to questions such as why doesn’t a wrapping <li> or neighbor <a> get an ID? Because of looking at the nature of some of these things more closely, we ultimately ended up cleaning up how some of these things are output to make it more consistent from Element to Element, which is why there is no longer an ID for dropdowns in the Navigation Inline Element. It’s sort of a nuanced discussion, but hopefully that helps to shed a little light on that particular situation.
As for your Content Editor not working, have you ensured that you’ve cleared all caches (browser, plugin, CDN, et cetera) upon updating? Have you followed our Update Guide exactly (found up in the global notice at the top of the site right now as the release has just come out). If you have, and you find that you’re still running into problems, we’ll need you to provide us with your login credentials in a secure note to take a close look at things since this deals with the backend of your site.
Hopefully that all helps to point you in the right direction. Cheers!
let me rephrase.
<ul class="e7-6 x-menu x-menu-inline">
This is the <ul> tag that is currently created when I add an inline menu element to the header builder.
<ul id="menu-main-menu" class="e7-6 x-menu x-menu-inline">
this is the markup that was generated before the update. the menu name is set to “main menu”. I did not add the ID myself. Before it was always automatically added.
I am able to add my own id via the builder, but its not adding the “menu-main-menu” id like it should.
@alex5252, that is the intended behavior. Because our menus already feature heavily altered markup and are put into numerous different situations (sometimes as a singular top level element, sometimes as a broken out secondary element, sometimes as a child within a parent wrapper, et cetera), we don’t output an ID unless specified to keep it consistent with how our other elements behave (unless it’s a dropdown, which will receive an ID that has to match up with our ARIA accessibility implementations). If you need an ID on a menu, you can certainly assign one as needed.
This topic was automatically closed 10 days after the last reply. New replies are no longer allowed.