Hi, I hope I’m explaining this correctly, but one of my websites has ID links, so that the ‘About Us’ and ‘Services’ menu links go to the relevant sections on the Home page. They used to work fine, but after updating to the most recent version of X Theme, they don’t work any more! I have no idea why either, as I’ve checked the ID in Cornerstone and they’re both still there and the custom links in the menu are fine too. Are you able to take a look for me as it’s very frustrating!
Thanks!
Hey @core365,
This is most probably coming from your custom JS related to links. Would you mind removing all the Custom JS in your site first? Please remove first the one in your Theme Options > JS.
Have you also tried testing for a plugin conflict?
If that does not help, please copy your site to a staging server and give us WordPress Admin and FTP access.
Thanks.
Hi, it does seem to be related to the custom JS - you very kindly provided me with this yourselves previously! I’ve tried taking bits out of it and then page anchor links then work, however the top bar disappears when scrolling down! I’ve put all the JS back in as to how it was and wondered if you’d be able to take a look for me?!!
I’ll put the admin login details in a secure note.
Many thanks!
Please convert your X license to Pro in order to achieve a multiple sticky bar. Almost all the functionality in that custom code like scrolling to a section when a hash in the URL is present and offsetting the sticky bars and WP Admin Bar are available in Pro too.
Please also note that we do not support issues coming from custom code even if we have given it here in the forum. They only serve as a guide. Even workarounds might not work in the future and we could not support it because custom codes are not maintainable.
Thank you for understanding.
Sorry, I don’t understand! It was working fine until I updated to the latest version so I don’t see why I need to pay out more money for the Pro licence! Can you explain why it was working perfectly fine before and now it doesn’t after updating it to the latest version.
Cheers
Hi @core365,
It should be okay now, it’s the Wordpress update that breaks your code in which jQuery library animation no longer hs a built-in easing/effect. I just did remove the easing from the code. This is the original code, I’m just adding it here as youre backup copy and for reference
jQuery(document).ready(function($) {
var $window = $(window);
var $this = $(this);
var $body = $('body');
var $navbar = $('.x-navbar');
var $topbar = $('.x-topbar');
var $logobar = $('.x-logobar');
var $navbarWrap = $('.x-navbar-fixed-top-active .masthead');
if ( ! $body.hasClass('page-template-template-blank-3-php') && ! $body.hasClass('page-template-template-blank-6-php') && ! $body.hasClass('page-template-template-blank-7-php') && ! $body.hasClass('page-template-template-blank-8-php') ) {
if ( $body.hasClass('x-boxed-layout-active') && $body.hasClass('x-navbar-fixed-top-active') && $body.hasClass('admin-bar') ) {
$window.scroll(function() {
var $adminbarHeight = $('#wpadminbar').outerHeight();
var $menuTop = $navbarWrap.offset().top - $adminbarHeight;
var $current = $(this).scrollTop();
if ($current > $menuTop) {
$navbar.addClass('x-navbar-fixed-top x-container-fluid max width');
$topbar.addClass('x-topbar-fixed-top x-container-fluid max width');
$logobar.addClass('x-logobar-fixed-top x-container-fluid max width');
} else {
$navbar.removeClass('x-navbar-fixed-top x-container-fluid max width');
$topbar.removeClass('x-topbar-fixed-top x-container-fluid max width');
$logobar.removeClass('x-logobar-fixed-top x-container-fluid max width');
}
});
} else if ( $body.hasClass('x-navbar-fixed-top-active') && $body.hasClass('admin-bar') ) {
$window.scroll(function() {
var $adminbarHeight = $('#wpadminbar').outerHeight();
var $menuTop = $navbarWrap.offset().top - $adminbarHeight;
var $current = $(this).scrollTop();
if ($current > $menuTop) {
$navbar.addClass('x-navbar-fixed-top');
$topbar.addClass('x-topbar-fixed-top');
$logobar.addClass('x-logobar-fixed-top');
} else {
$navbar.removeClass('x-navbar-fixed-top');
$topbar.removeClass('x-topbar-fixed-top');
$logobar.removeClass('x-logobar-fixed-top');
}
});
} else if ( $body.hasClass('x-boxed-layout-active') && $body.hasClass('x-navbar-fixed-top-active') ) {
$window.scroll(function() {
var $menuTop = $navbarWrap.offset().top;
var $current = $(this).scrollTop();
if ($current > $menuTop) {
$navbar.addClass('x-navbar-fixed-top x-container-fluid max width');
$topbar.addClass('x-topbar-fixed-top x-container-fluid max width');
$logobar.addClass('x-logobar-fixed-top x-container-fluid max width');
} else {
$navbar.removeClass('x-navbar-fixed-top x-container-fluid max width');
$topbar.removeClass('x-topbar-fixed-top x-container-fluid max width');
$logobar.removeClass('x-logobar-fixed-top x-container-fluid max width');
}
});
} else if ( $body.hasClass('x-navbar-fixed-top-active') ) {
$window.scroll(function() {
var $menuTop = $navbarWrap.offset().top;
var $current = $(this).scrollTop();
if ($current > $menuTop) {
$navbar.addClass('x-navbar-fixed-top');
$topbar.addClass('x-topbar-fixed-top');
$logobar.addClass('x-logobar-fixed-top');
} else {
$navbar.removeClass('x-navbar-fixed-top');
$topbar.removeClass('x-topbar-fixed-top');
$logobar.removeClass('x-logobar-fixed-top');
}
});
}
}
});
(function($){
$(window).on('load', function(){
$('.x-nav-tabs .x-nav-tabs-item').removeClass('active');
$('.x-tab-content .x-tab-pane').removeClass('active');
});
})(jQuery);
jQuery(document).ready(function($) {
var $body = $('body');
var bodyHeight = $body.outerHeight();
var adminbarHeight = $('#wpadminbar').outerHeight();
var navbarFixedTopHeight = $('.x-topbar').outerHeight()+$('.x-navbar').outerHeight();
var locHref = location.href;
var locHashIndex = locHref.indexOf('#');
var locHash = locHref.substr(locHashIndex);
var dragging = false;
$body.on('touchmove', function() {
dragging = true;
} );
$body.on('touchstart', function() {
dragging = false;
} );
//
// Calculate the offset height for various elements and remove it from
// the element's top offset so that fixed elements don't cover it up.
//
function animateOffset( element, ms, easing ) {
$('html, body').animate({
scrollTop: $(element).offset().top - adminbarHeight - navbarFixedTopHeight + 1
}, ms, easing);
}
//
// Page load offset (if necessary).
//
$(window).load(function() {
if ( locHashIndex !== -1 && $(locHash).length ) {
animateOffset(locHash, 1, 'linear');
}
});
//
// Scroll trigger.
//
$('a[href*="#"]').unbind('touchend click').on('touchend click', function(e) {
console.log($('.hm1.x-bar-fixed').outerHeight());
href = $(this).attr('href');
notComments = href.indexOf('#comments') === -1;
if ( href !== '#' && notComments ) {
var theId = href.split('#').pop();
var $el = $('#' + theId);
if ( $el.length > 0 ) {
e.preventDefault();
if (dragging) {
return;
}
animateOffset($el, 850, 'easeInOutExpo');
}
}
});
});
jQuery(document).ready(function($){
$('.x-nav li').each(function(){
$(this).removeClass('current-menu-item');
});
$('.current_page_item').addClass('current-menu-item');
$('.x-nav li').click(function(){
$('.x-nav li').each(function(){
$(this).removeClass('current-menu-item');
});
$(this).addClass('current-menu-item');
});
});
New one
jQuery(document).ready(function($) {
var $window = $(window);
var $this = $(this);
var $body = $('body');
var $navbar = $('.x-navbar');
var $topbar = $('.x-topbar');
var $logobar = $('.x-logobar');
var $navbarWrap = $('.x-navbar-fixed-top-active .masthead');
if ( ! $body.hasClass('page-template-template-blank-3-php') && ! $body.hasClass('page-template-template-blank-6-php') && ! $body.hasClass('page-template-template-blank-7-php') && ! $body.hasClass('page-template-template-blank-8-php') ) {
if ( $body.hasClass('x-boxed-layout-active') && $body.hasClass('x-navbar-fixed-top-active') && $body.hasClass('admin-bar') ) {
$window.scroll(function() {
var $adminbarHeight = $('#wpadminbar').outerHeight();
var $menuTop = $navbarWrap.offset().top - $adminbarHeight;
var $current = $(this).scrollTop();
if ($current > $menuTop) {
$navbar.addClass('x-navbar-fixed-top x-container-fluid max width');
$topbar.addClass('x-topbar-fixed-top x-container-fluid max width');
$logobar.addClass('x-logobar-fixed-top x-container-fluid max width');
} else {
$navbar.removeClass('x-navbar-fixed-top x-container-fluid max width');
$topbar.removeClass('x-topbar-fixed-top x-container-fluid max width');
$logobar.removeClass('x-logobar-fixed-top x-container-fluid max width');
}
});
} else if ( $body.hasClass('x-navbar-fixed-top-active') && $body.hasClass('admin-bar') ) {
$window.scroll(function() {
var $adminbarHeight = $('#wpadminbar').outerHeight();
var $menuTop = $navbarWrap.offset().top - $adminbarHeight;
var $current = $(this).scrollTop();
if ($current > $menuTop) {
$navbar.addClass('x-navbar-fixed-top');
$topbar.addClass('x-topbar-fixed-top');
$logobar.addClass('x-logobar-fixed-top');
} else {
$navbar.removeClass('x-navbar-fixed-top');
$topbar.removeClass('x-topbar-fixed-top');
$logobar.removeClass('x-logobar-fixed-top');
}
});
} else if ( $body.hasClass('x-boxed-layout-active') && $body.hasClass('x-navbar-fixed-top-active') ) {
$window.scroll(function() {
var $menuTop = $navbarWrap.offset().top;
var $current = $(this).scrollTop();
if ($current > $menuTop) {
$navbar.addClass('x-navbar-fixed-top x-container-fluid max width');
$topbar.addClass('x-topbar-fixed-top x-container-fluid max width');
$logobar.addClass('x-logobar-fixed-top x-container-fluid max width');
} else {
$navbar.removeClass('x-navbar-fixed-top x-container-fluid max width');
$topbar.removeClass('x-topbar-fixed-top x-container-fluid max width');
$logobar.removeClass('x-logobar-fixed-top x-container-fluid max width');
}
});
} else if ( $body.hasClass('x-navbar-fixed-top-active') ) {
$window.scroll(function() {
var $menuTop = $navbarWrap.offset().top;
var $current = $(this).scrollTop();
if ($current > $menuTop) {
$navbar.addClass('x-navbar-fixed-top');
$topbar.addClass('x-topbar-fixed-top');
$logobar.addClass('x-logobar-fixed-top');
} else {
$navbar.removeClass('x-navbar-fixed-top');
$topbar.removeClass('x-topbar-fixed-top');
$logobar.removeClass('x-logobar-fixed-top');
}
});
}
}
});
(function($){
$(window).on('load', function(){
$('.x-nav-tabs .x-nav-tabs-item').removeClass('active');
$('.x-tab-content .x-tab-pane').removeClass('active');
});
})(jQuery);
jQuery(document).ready(function($) {
var $body = $('body');
var bodyHeight = $body.outerHeight();
var adminbarHeight = $('#wpadminbar').outerHeight();
var navbarFixedTopHeight = $('.x-topbar').outerHeight()+$('.x-navbar').outerHeight();
var locHref = location.href;
var locHashIndex = locHref.indexOf('#');
var locHash = locHref.substr(locHashIndex);
var dragging = false;
$body.on('touchmove', function() {
dragging = true;
} );
$body.on('touchstart', function() {
dragging = false;
} );
//
// Calculate the offset height for various elements and remove it from
// the element's top offset so that fixed elements don't cover it up.
//
function animateOffset( element, ms ) {
$('html, body').animate({
scrollTop: $(element).offset().top - adminbarHeight - navbarFixedTopHeight + 1
}, ms);
}
//
// Page load offset (if necessary).
//
$(window).load(function() {
if ( locHashIndex !== -1 && $(locHash).length ) {
animateOffset(locHash, 1);
}
});
//
// Scroll trigger.
//
$('a[href*="#"]').unbind('touchend click').on('touchend click', function(e) {
console.log($('.hm1.x-bar-fixed').outerHeight());
href = $(this).attr('href');
notComments = href.indexOf('#comments') === -1;
if ( href !== '#' && notComments ) {
var theId = href.split('#').pop();
var $el = $('#' + theId);
if ( $el.length > 0 ) {
e.preventDefault();
if (dragging) {
return;
}
animateOffset($el, 850);
}
}
});
});
jQuery(document).ready(function($){
$('.x-nav li').each(function(){
$(this).removeClass('current-menu-item');
});
$('.current_page_item').addClass('current-menu-item');
$('.x-nav li').click(function(){
$('.x-nav li').each(function(){
$(this).removeClass('current-menu-item');
});
$(this).addClass('current-menu-item');
});
});
Please note that we don’t do code maintenance, it’s only good for the version it was implemented. But this should serve a reference in case you’ll hire a developer or webmaster that will maintain your site.
Thanks!
Hi @Rad, thank you so much and I appreciate you explaining it was the Wordpress update that was the issue!
It’s back to working as it was before! Thank you for taking the time to look into this and sort it out for me!
Thanks!
You’re most welcome.
This topic was automatically closed 10 days after the last reply. New replies are no longer allowed.