Tagged: x
-
AuthorPosts
-
January 15, 2017 at 5:54 am #1330709
envato_2015ParticipantWhen using a non-footer template, css rule
.x-container.main:beforecauses a duplicate vertical scrollbar making vertical scrolling extremely sloppy, especially on mobile.Steps to reproduce:
- go to http://demo.theme.co/ethos-1/
- remove top and bottom footer from DOM
- X-perience a second vertical scrollbar
Probably something about collapsing margins not happening if there’s no element following
.x-container.main.Two solutions came up to my mind:
- .x-container.main:before { bottom: 0; } (keeping it all in one rule)
or - .x-container.main:after { display: block; }
January 15, 2017 at 6:09 am #1330717
ChristopherModeratorHi there,
Please add following code in Customize -> Custom -> Global CSS :
body { overflow: hidden; }Hope that helps.
January 15, 2017 at 6:29 am #1330729
envato_2015ParticipantThank you for your instant reply.
Since this is a core bug, you should fix it inside X itself using one of the supplied solutions above or by implementing your own.
January 15, 2017 at 7:09 am #1330752
ChristianModeratorHey there,
Please give us the URL of the page you’re having issue with so we could see the setup. Also give us access to your WordPress admin.
We could not consider this a bug by removing elements in the DOM only. I enabled a no footer template in my test site but I don’t get this issue.
Thanks.
January 15, 2017 at 10:34 am #1330892
envato_2015ParticipantHere comes a more generic test case (validated in both Chrome and Firefox):
- create a new page
- set its template to “Blank – Container | No Header, No Footer”
- add some content
- visit the page
- resize the window vertically to become smaller than the content
- X-perience the duplicate vertical scrollbar
Fix:
.x-container.main:before { /* top: 0; not sure if this is safe to be left out for every case */ bottom: 0; }.
January 15, 2017 at 7:51 pm #1331361
Rue NelModeratorHello There,
Thanks for updating in! I have carefully followed the steps and I could not replicate the issue. I am just seeing this: http://prntscr.com/dw4u7m
Could you please provide us with a screenshot or a video capture so that we will have an idea of what is going with the issue?
Thank you very much.
January 16, 2017 at 5:51 am #1331890
envato_2015ParticipantHi,
built another test from scratch with all plugins disabled. Even commented out all custom css generated by X (made no difference, though). The page contains a single paragraph and has its template set to “Blank – Container | No Header, No Footer”.
Result as shown in the screenshot (upper gray line is the bookmarks bar). If the window is large enough to contain all content at once, a single scrollbar will be there nonetheless. Upon reducing window height, a second scrollbar will appear.
Full HTML source can be found at http://pastebin.com/wVKuMwgt Links are all relativized so you can just save this in a file inside document root and see if you can reproduce the issue.
WP 4.7.1
X 4.6.4Tested with
- Chrome 55.0.2883.95
- Firefox 50.1.0
January 16, 2017 at 6:35 am #1331937
ChristianModeratorI’ve followed your instruction yet I don’t get this issue. See http://dev-nisardfi.pantheonsite.io/test/. Please try clearing your browser cache. Please also give us access to your WordPress admin and what OS and browser you’re using.
Thanks.
January 16, 2017 at 9:07 am #1332073
envato_2015ParticipantThank you for your instant reply containing your testing site url which finally shed some light!
Please show some love for the thread title and set your stack to Ethos accordingly. The rule causing the second scrollbar can only be found in wp-content/themes/x/framework/css/src/site/_scss/stacks/ethos/_scaffolding.scss
No other stack seems to contain any element addressed by
.x-container.mainas well.January 16, 2017 at 9:51 am #1332126
ChristianModeratorSorry I missed it. I’ll report this to our development team.
Thanks.
-
AuthorPosts
- <script> jQuery(function($){ $("#no-reply-1330709 .bbp-template-notice, .bbp-no-topic .bbp-template-notice").removeClass('bbp-template-notice'); }); </script>
