Navigation
This is archived content. Visit our new forum.

Tagged: 

  • Author
    Posts
  • #1310581
    Meng
    Participant

    I have observed the following bug between X Theme and Revslider:

    When a slider is configured to display post content such as excerpt text, it incorrectly parses any html content within the slide excerpt such as <strong> tags, leading to unclosed html tags that affect the remainder of the webpage. Please advise on the correct solution to mitigate this effect, thank you very much! πŸ™‚

    P.S. An early Happy New Year to you all! πŸ™‚

    #1310583
    Meng
    Participant
    This reply has been marked as private.
    #1310751
    Rue Nel
    Moderator

    Hello There,

    Thanks for writing in! An excerpt should not have any html codes to prevent any conflict that might messed the layout. I would recommend that you manually add excerpts to each of your post. To know more about manual excerpts, please check it here: https://codex.wordpress.org/Excerpt

    Hope this helps.

    #1312543
    Meng
    Participant

    Hi Rue Nel!

    First of all, best wishes for 2017 πŸ™‚

    Regarding your reply: yes, I am aware of this. However, the excerpt is supposed to be a plaintext string, right? It should be able to filter out any HTML code in the post body itself? *

    What surprises me is that the slider apparently grabs the <strong> HTML tag by its own. Either it uses the wrong function to get the text, or something is not going right between the theme and the slider, I suspect.

    * See: https://developer.wordpress.org/reference/functions/the_excerpt/
    An auto-generated excerpt will also have all shortcodes and tags removed. It is trimmed down to a word-boundary and the default length is 55 words.
    See also: https://developer.wordpress.org/reference/functions/get_the_excerpt/

    #1312669
    Christian
    Moderator

    Looks like Slider Revolution has a problem with if you wrap all your text with the strong tag. Please change it to paragraph tag instead and use strong tags inside it only (see attachment). This might not be a bug since the strong tag is a phrase tag so it should really not be used as a replacement for paragraph or for whole paragraph text.

    Thanks.

    #1312679
    Meng
    Participant

    Thanks. Because we as users are getting the plugin through ThemeCo, we can’t use ThemePunch Support to report this issue.

    @ThemeCo – As a development partner, could you please add an urgent ticket with ThemePunch to get this bug sorted? Thank you. I can’t expect all my users to pay attention to this detail, so the sooner the plugin is fixed the easier our lives become πŸ™‚

    #1312985
    Meng
    Participant

    @Christian / @ThemeCo

    I’ve just gotten word back from ThemePunch. Apparently they are unable to reproduce the issue. Could you look into this?

    https://codecanyon.net/item/slider-revolution-responsive-wordpress-plugin/2751380/comments?page=704&filter=all#comment_15193974
    After additional review we weren’t able to reproduce this one from our side. So your best bet here would be to contact your theme’s author and they should be able to assist you further with this.

    Concerning the whole thing about paragraph tags: if you write an article into WordPress it does not automatically add <p> tags around every paragraph when saving. And you surely do not expect all users to start manually adding html tags to their paragraphs?

    #1313745
    Christian
    Moderator

    Hey Meng,

    I’ve investigated further and the issue is because of the long text wrapped in a <strong> tag and half of that text is being cut off by the excerpt length limit so the ending </strong> tag is not included. In your Slider Settings, I’ve increased the limit of Limit The Excerpt To setting from 15 to 400 and the issue was fixed. This is regardless if you wrap your text with <p> tag. Sorry for the confusion.

    This is not an issue with X though as I have replicated this setup using 2015 theme and the issue persist. See the attachments.

    http://imgur.com/a/XJTqc

    I’ll forward this to our development team so they can. We can’t guarantee an immediate solution for this though as this is not an issue with X.

    #1316105
    Meng
    Participant

    @Christian thanks for looking it some more!

    I understand the problem, the slider can’t deal with the <strong> tag that is not closed within the ‘excerpt’ as far as it is being read. This is a problem with Revslider. It should be grabbing an excerpt using the WP get_the_excerpt function, but rather it’s generating its own excerpt from the post body. Which is why the html appears in the first place. (The WP excerpt is stripped of all html content)

    And I am also aware of several possible workarounds, but they do not work for me. I need that slider to use an excerpt of x words long. And I cannot expect users to start manually adding <p> tags everywhere. (This is just a dev sample, the problem persists on a live site too!)

    My point is that we need a fix for this from ThemePunch as soon as possible. And because we cannot contact them directly, you, @ThemeCo, need to do it for us. This is a serious bug in Revslider that needs to be addressed.

    So if you could do that for us, thank you very much, I’m grateful for your assistance πŸ™‚

    #1316854
    Rad
    Moderator

    Sure, we’ll let you know if we find something πŸ™‚ Thanks!

  • <script> jQuery(function($){ $("#no-reply-1310581 .bbp-template-notice, .bbp-no-topic .bbp-template-notice").removeClass('bbp-template-notice'); }); </script>