Tagged: x
-
AuthorPosts
-
October 20, 2016 at 8:50 am #1223887
louistParticipantAll the assets in Convertplug do not have alt tags.
“/wp-content/plugins/convertplug/modules/assets/images/white20.png”
Is there a simple function that would add an alt tag such as alt=”cb close” without modifying the plugin’s core? Or does the plugin dev need to come up with an update?
October 20, 2016 at 11:20 am #1224101
Nabeel AModeratorHi there,
Thanks for writing in! Can you please provide the URL of your site so we can take a look?
Thanks!
October 20, 2016 at 12:10 pm #1224170
louistParticipantThis reply has been marked as private.October 20, 2016 at 7:37 pm #1224618
Rue NelModeratorHello There,
Thank you for the clarifications. I can confirm that this is a bug in ConvertPlug. I have reported this already to the creators of the said plugin. The respective developers should check this out and when they have fixed it, it will be updated and will be rolled out in their next update release.
Please bear with us. Thank you for your understanding.
October 23, 2016 at 8:39 am #1227268
louistParticipantHi Rue Nel,
Thanks for the update.
However in the meantime can you help me find where in the plugin is the output? I’ve been trying to find where does the code generate the HTML and can’t find it. If I knew which file was generating that image tag I could easily add the temp fix until they actually fix the issue in a patch.
October 23, 2016 at 10:51 am #1227334
RupokMemberHi there,
We can’t recommend editing the plugin directly and as it’s not managed by Themeco, we can’t actually guide you on such customization as it’s pretty complex with number of modules. But I can assure that we have sent them a report to fix this asap.
Thanks for understanding.
October 24, 2016 at 10:05 am #1228426
louistParticipantHi Rupok,
That wasn’t helpful.. but I understand. I actually found a temp fix. In my case this issue being very urgent we had to come up with a fix.
Anyways I edited the plugin’s file (even if it’s a big no-no). For those interested PROCEED AT YOUR OWN RISK (no kidding)
THIS ONLY APPLIES IF YOU’RE USING AN IMAGE TO CLOSE YOUR MODAL/SLIDE-IN/INFO-BAR
Although the code seems correct, the issue stems from the img class not being fetched by the plugin’s function. All you need to do is add an img class manually.
Convertplug is divided into modules so if you’re using modals you would need to edit the modal’s functions.php. Slide-in and Info-bar have their own functions.php
Look for this line in the functions.php
$close_img = $icon_url;It should be located towards the end of the document.
Add the following lines right after:
//TEMP FIX $close_img_class = "cp-default-close"; $close_alt = $close_img_class;I suggest you leave the comment line in case you ever need to find this again. THIS SNIPPET WILL DISAPPEAR in the next Convertplug update. If they do not solve the issue, you can try adding these new lines again. This is a TEMPORARY SOLUTION for adding the alt tag until the next Convertplug update.
October 24, 2016 at 11:25 am #1228537
RupokMemberHi there,
Thanks for sharing. You can use this temp fix as you seems experienced but we never recommend editing any plugin directly for general users. But if you can keep your changes as backup while performing updates, you can proceed but it’s still we can’t assist on such customization.
Hope this makes sense.
-
AuthorPosts
- <script> jQuery(function($){ $("#no-reply-1223887 .bbp-template-notice, .bbp-no-topic .bbp-template-notice").removeClass('bbp-template-notice'); }); </script>
