[guy_bParticipant]

Hi,

Considering the size of X, it is very cleanly coded. There are a few flags though, perhaps the developers are already aware of them:

• REQUIRED:.gallery-caption css class is needed in your theme css.

• RECOMMENDED: Text domain problems in wp-footer.php. You have not included a text domain!
Line 26: <?php _e( ‘Copyright © ‘ ); ?>

• WARNING: Found base64_encode in the file framework/functions/global/admin/addons/class-update-api.php. base64_encode() is not allowed.
Line 135: return self::remote_request( array( ‘products’ => base64_encode( serialize( $slugs ) ) ) );

• WARNING: file_get_contents was found in the file framework/functions/global/admin/addons/page-customizer-manager.php File operations should use the WP_Filesystem methods instead of direct PHP filesystem calls.
Line 64: $encoded_options = file_get_contents( $_FILES[‘import’][‘tmp_name’] );

• REQUIRED: The theme uses the register_taxonomy() function, which is plugin-territory functionality.

• REQUIRED: The theme uses the register_post_type() function, which is plugin-territory functionality.

• REQUIRED: Found a Customizer setting that did not have a sanitization callback function. Every call to the add_setting() method needs to have a sanitization callback function passed.

• REQUIRED: screen_icon() found in the file framework/functions/global/admin/tmg/activation.php. Deprecated since version 3.8.
Line 372: <?php screen_icon( apply_filters( ‘tgmpa_default_screen_icon’, ‘themes’ ) ); ?>
Line 1497: screen_icon( apply_filters( ‘tgmpa_default_screen_icon’, ‘themes’ ) );

• REQUIRED: framework/functions/global/admin/tmg/activation.php. Themes should use add_theme_page() for adding admin pages.
Line 336: add_submenu_page(

• REQUIRED: framework/functions/global/admin/addons/setup.php. Themes should use add_theme_page() for adding admin pages.
Line 77: add_menu_page( ‘X – Addons: Home’, ‘Addons’, ‘manage_options’, ‘x-add

• RECOMMENDED: Screenshot size should be 880×660, to account for HiDPI displays. Any 4:3 image size is acceptable, but 880×660 is preferred.

• RECOMMENDED: Possible variable $this found in translation function in framework/functions/global/admin/tmg/activation.php. Translation function calls must NOT contain PHP variables.
Line 376: <?php if ( isset( $this->message ) ) _e( wp_kses_post( $this->message ), ‘__x__’ ); ?>

• RECOMMENDED: Possible variable $cvalue found in translation function in woocommerce/cart/shipping-calculator.php. Translation function calls must NOT contain PHP variables.
Line 56: echo ‘<option value=” . esc_attr( $ckey ) . ” ‘ . selected( $current_r, $ckey, false ) . ‘>’ . __( esc_html( $cvalue ), ‘__x__’ ) .'</option>’;

• RECOMMENDED: No reference to add_theme_support( “title-tag” ) was found in the theme. It is recommended that the theme implement this functionality for WordPress 4.1 and above.

• RECOMMENDED: No reference to add_theme_support( “custom-header”, $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.

• RECOMMENDED: No reference to add_theme_support( “custom-background”, $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.

• RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

• RECOMMENDED: Tags: is either empty or missing in style.css header.

[ChristianModerator]

Hey there,

Thanks for your feedback. I’ll forward this list to our development team.

[Author]

Posts