[mike-moonrayParticipant]

My clients testimonials slider had broken, and as I dug I realized that along with the slider, about 80% of my custom javascript had broken as well.

As I dug, I realized that at some point in the last release or so, the fitText function was renamed to csFitText. That broke all the responsive text on my clients site, along with several other customizations I’d created for them that appeared after the fitText calls.

ThemeCo, I really love the X Theme, but if you’re renaming functions that I’m calling in my js files, then you need to pass that onto us, explicitly!

Luckily it didn’t cost my client any leads, but it was embarassing to have my new clients site suddenly lose functionality. It could easily have broken something major that could have cost them money, and me a client.

[RadModerator]

Hi there,

Thanks for posting in and sorry to hear that. I’ll forward your concern.

Though, the cornerstone is not really meant to be customized. The core and its files are compiled and any customization done with it will be overwritten by updates. If you’re calling some cornerstone’s core functions, then it’s best to add some note of the changes just in case you need to change it again.

This is unavoidable especially if the main purpose of the update (function’s name change) is to avoid conflict with other existing functions or library.

Thanks again, noted that 🙂

[Author]

Posts