Docs

[Brennen Smith]

Hi X,

We recently upgraded a client site to X 4.4.2 from X 2.5.0 (we we’re encountering some serious issues parsing the base64 encoded data in a custom HTML element). While the upgrade went reasonably smoothly, we discovered a major issue – Accordions are completely broken.

It only appears when users are not logged in (99% of visitors). There are no errors in the console, or any issues with file transfers. We have completely flushed the cache and CDN (and tested it in a no-caching dev environment) with the same results.

It appears an event.preventdefault() isn’t getting attached, but we have no idea where.

A staging version of the site is here: http://ecta.wildwingstudios.com/classes/. We rolled the production site back to a snapshot before the upgrade and it is located here: http://emeraldcitytrapeze.com/

Any assistance would be greatly appreciated!

Best,

Brennen Smith
Wild Wing Studios

[Rupok]

Hi Brennen,

Thanks for writing in! As you have built the site with very older version of X so I assume either you have used the shortcode or Visual Composer to build the accordions. Would you kindly review the example on demo here (http://theme.co/x/demo/integrity/1/shortcodes/accordion/) to make sure something isn’t missing from the shortcode. Do the same if you use Visual Composer. To test this, just add a new test page and add the accordions again as new items and see if that works. That is try to reproduce this with a new page.

Let us know how it goes.

Cheers!

[Brennen Smith]

Hi Rupok,

It is indeed an old version of X – one of the first that we built with X, and way before the auto-update/in place update system existed :).

Thanks for the idea of creating a fresh page and testing a new accordion elem. We created a new page here: http://ecta.wildwingstudios.com/x-theme-support-test/ and it does appear that the accordions are working, albeit they are completely different than the previous style (see: http://ecta.wildwingstudios.com/classes/).

With that said, it looks like VC is using a completely different tag to generate these accordions. With the legacy system, it used the [accordion][accordion_item title=""] convention (which is what is used across the site). Now the new system uses [vc_tta_accordion][vc_tta_section title="Section 1" tab_id=""].

What this means is that to perform this upgrade, we would have to refactor our entire codebase on this site to this new format. Not a trivial task since tab_id needs to be unique.

When was the [accordion] style of short-code deprecated? I can’t find any reference to it in the changelogs?

[Brennen Smith]

Hi Rupok,

My apologies about the mis-information above, I did not realize that there are now two types of accordions in VC. My mistake about [accordion] being deprecated!

With that said, the accordions (of both types) exists here: http://ecta.wildwingstudios.com/x-theme-support-test/

The [vc_tta_accordion] shortcode accordion works great, however the [accordion] accordion has the primary issue of redirecting to /undefined.

The code of the page is here:
`
[vc_row padding_top=”0px” padding_bottom=”0px”][vc_column fade_animation_offset=”45px” width=”1/1″][vc_tta_accordion][vc_tta_section title=”Section 1″ tab_id=”1461860225343-4c891d14-98c0″][text_output]This is the text of section 1[/text_output][/vc_tta_section][vc_tta_section title=”This is Section 2″ tab_id=”1461860225387-452dc5d0-df8a”][text_output]This is the text of section 2[/text_output][/vc_tta_section][/vc_tta_accordion][/vc_column][vc_column fade_animation_offset=”45px”][accordion id="" class="" style=""][accordion_item parent_id="" title="" id="" class="" style=""]test[/accordion_item][/accordion][/vc_column][/vc_row]
`

[Rue Nel]

Hello There,

Would you mind providing us the url of your site with login credentials so we can take a closer look? This is to ensure that we can provide you with a tailored answer to your situation. Once you have provided us with your URL, we will be happy to assist you with everything.

To do this, you can make a post with the following info:
– Link to your site

– WordPress Admin username / password

Don’t forget to select Set as private reply. This ensures your information is only visible to our staff.

For the meantime, you could try testing for a plugin conflict. You can do this by deactivating all third party plugins, and seeing if the problem remains. If it’s fixed, you’ll know a plugin caused the problem, and you can narrow down which one by reactivating them one at a time.

Please let us know how it goes.

[Brennen Smith]

This reply has been marked as private.

[Brennen Smith]

Hi X,

We tried your suggestion of deactivating 3rd party plugins, and we discovered that one (WP Google Analytics) was causing the issue! We will migrate GA over to your plugin, and I appreciate all of the help. Feel free to consider this issue closed.

Best,

Brennen Smith

[Thai]

Glad you’ve sorted it out, Brennen 🙂

If you need anything else please let us know.

[Author]

Posts