Tagged: x
-
AuthorPosts
-
April 14, 2016 at 5:03 pm #883181
RadModeratorHi there,
I checked your testing/staging site and yes, accordion works on mobile. Your main site probably has caching or internal caching issue. Would you mind providing a login that has admin capability?
Thanks!
April 18, 2016 at 8:27 am #888237
jasonribeiroParticipantSame login info for both sites. Did you recently make any changes on MyKCM.com…because we are in the middle of a launch and now the site seems to have gone back to those screenshots that I previously sent with the shortcodes not processing correctly.
April 18, 2016 at 9:08 am #888309
jasonribeiroParticipantPlease respond ASAP…we are experiencing issues on both the live and test site all of a sudden. Have you made any changes to either?
April 18, 2016 at 9:58 am #888409
jasonribeiroParticipantNevermind, ok we think we figured that piece of it out for now. However, the original issue still stands…the accordion element does not work on mobile devices and upon updating Cornerstone, shortcodes seem to break.
Is there anything you did with the test site (kcmatters.com)? Because I can no longer login to it with caseymyers123@gmail.com.
April 18, 2016 at 3:18 pm #888902
jasonribeiroParticipantfigured out the login piece…original accordion issue still not working. Please advise.
April 19, 2016 at 3:16 am #889521
JackKeymasterHi there,
Thanks for writing back.
Go to x/framework/js/dist/site/x-body.js
And on line 1946, change that code to:
`//
// Scroll trigger.
//$(‘a[href*=”#”]’).on(‘touchstart click’, function(e) {
href = $(this).attr(‘href’);
notComments = href.indexOf(‘#comments’) === -1;
if ( href !== ‘#’ && notComments ) {
notAccordion = href.indexOf(‘#collaspe-‘) === -1;
notTabbedContent = href.indexOf(‘#tab-‘) === -1;
if ( href !== ‘#’ && notComments && notAccordion && notTabbedContent ) {
var theId = href.split(‘#’).pop();
var $el = $(‘#’ + theId);
if ( $el.length > 0 ) {
e.preventDefault();
animateOffset($el, 850, ‘easeInOutExpo’);
}
}`Please note, you’ll then need to re-compile x-body.js, to it’s minified form, and update that file as well. Then see if the accordions work. This should fix a issue with tabs and accordions not working on mobile devices.
Thanks!
April 20, 2016 at 9:10 am #891839
jasonribeiroParticipantI have edited both files and uploaded them to the same directory of the Theme X child theme that I am using. However, nothing appears to have changed. Am I missing something?
April 20, 2016 at 8:37 pm #892764
Rue NelModeratorHello There,
Adding the modified JS files in your child theme will not work. As what we have mentioned before, you’ll need to re-compile x-body.js, to it’s minified form, and update that file as well. This changes will be placed in the same original location of the file.
Hope this helps.
April 21, 2016 at 10:51 am #893886
jasonribeiroParticipantOK, I added it the the actual theme and not the child theme. The accordions still do not work on mobile. Please advise.
April 22, 2016 at 1:17 am #894847
RadModeratorHi there,
But that still need recompilation, that’s the downside of editing core files that are not meant to be edited.
Please provide your FTP login credentials in private reply as well. I check if it’s possible to recompile.
Thanks!
April 25, 2016 at 9:53 am #898730
jasonribeiroParticipantI did recompile. I edited the one file and then recompiled the other one…is there something that I’m missing?
April 26, 2016 at 4:27 am #899984
JackKeymasterHi there,
Thanks for your reply.
Can you please provide your FTP details in a private reply please so I can take a closer look at this for you.
Thanks!
-
AuthorPosts
- <script> jQuery(function($){ $("#no-reply-865909 .bbp-template-notice, .bbp-no-topic .bbp-template-notice").removeClass('bbp-template-notice'); }); </script>
